chore: Replace `time.Date` with `referenceTime` by gmlewis · Pull Request #4325 · google/go-github

gmlewis · 2026-06-23T20:15:14Z

Fixes: #4324.
Closes: #4326.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

codecov · 2026-06-23T20:18:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (642da7d) to head (73933c3).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4325   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         193      193           
  Lines       19400    19400           
=======================================
  Hits        18912    18912           
  Misses        270      270           
  Partials      218      218

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis · 2026-06-23T20:26:29Z

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

stevehipwell

@gmlewis sorry for being dense, but I think I'm missing how the +referenceTimeStr+ string works and why it needs to use a ` instead of "?

gmlewis · 2026-06-24T11:31:41Z

@gmlewis sorry for being dense, but I think I'm missing how the +referenceTimeStr+ string works and why it needs to use a instead of"`?

Oh, it just keeps the double quote characters in the string.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis · 2026-06-24T16:51:45Z

OK, I took a slightly different approach and used unix-seconds-since-epoch for all cases where different timestamps are valuable. I believe that this approach combines the best of both worlds.

Please take another look when you get a chance.

cc: @stevehipwell - @alexandear

gmlewis · 2026-06-24T19:42:44Z

Thank you, @alexandear!
Merging.

chore: Replace time.Date with referenceTime

1a6dc0f

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis added 2 commits June 23, 2026 16:21

Cleanup

0c9f706

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Cleanup

611d23b

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 23, 2026

stevehipwell reviewed Jun 24, 2026

View reviewed changes

alexandear mentioned this pull request Jun 24, 2026

test: use reference timestamp helpers in projects tests #4326

Closed

alexandear reviewed Jun 24, 2026

View reviewed changes

Comment thread github/actions_workflow_runs_test.go Outdated

Comment thread github/git_commits_test.go

Comment thread github/rate_limit_test.go

gmlewis added 20 commits June 24, 2026 09:39

Fix rate_limit_test.go

0a0aa5c

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Revert git_commits_test.go changes

def77c9

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix actions_workflow_runs_test.go

edb714c

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix actions_secrets_test.go

351fafd

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix actions_variables_test.go

1f498af

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix actions_workflow_jobs_test.go

6cb88ec

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix actions_workflows_test.go

d8e0dc8

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix activity_notifications_test.go and repos_commits_test.go

36d22fe

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix admin_users_test.go

89e2c28

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix apps_test.go

4646a70

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix code_scanning_test.go

37db75c

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix codespaces_secrets_test.go

94a5fde

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix codespaces_test.go

76b4362

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix copilot_test.go

ab27bdd

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix dependabot_secrets_test.go

f2ef4ea

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix enterprise_manage_ghes_config_test.go

2f7e925

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix enterprise_team_test.go

2994398

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix gists_test.go

aafb0b4

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/orgs_credential_authorizations_test.go

1e0433d

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/orgs_custom_repository_roles_test.go

8a72a2b

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

gmlewis added 11 commits June 24, 2026 12:00

Fix github/orgs_issue_types_test.go

8e3511b

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/orgs_members_test.go

dea9370

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/orgs_organization_roles_test.go

7585773

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/orgs_personal_access_tokens_test.go

bb0db51

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/private_registries_test.go

25988b5

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/repos_test.go

b70e6aa

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/scim_test.go

8f67dd1

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/secret_scanning_test.go

7b33125

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/security_advisories_test.go

90e6202

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/teams_discussion_comments_test.go

96852cb

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix github/teams_discussions_test.go

c73aa69

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Merge branch 'master' into i4324-referenceTime

73933c3

alexandear approved these changes Jun 24, 2026

View reviewed changes

gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 24, 2026

gmlewis merged commit 595de3d into google:master Jun 24, 2026
15 checks passed

gmlewis deleted the i4324-referenceTime branch June 24, 2026 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Replace `time.Date` with `referenceTime`#4325

chore: Replace `time.Date` with `referenceTime`#4325
gmlewis merged 35 commits into
google:masterfrom
gmlewis:i4324-referenceTime

gmlewis commented Jun 23, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

gmlewis commented Jun 23, 2026

Uh oh!

stevehipwell left a comment

Uh oh!

gmlewis commented Jun 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis commented Jun 24, 2026

Uh oh!

gmlewis commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

gmlewis commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis commented Jun 23, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis commented Jun 24, 2026

Uh oh!

gmlewis commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmlewis commented Jun 23, 2026 •

edited

Loading

codecov Bot commented Jun 23, 2026 •

edited

Loading

gmlewis commented Jun 24, 2026 •

edited

Loading